Re: FVWM: RaiseWindow bug fix

From: Richard Lister <listerrj_at_helios.aston.ac.uk>
Date: Thu, 13 Jun 1996 12:05:22 +0100

On Wed, 12 Jun 96 22:35 BST
Austin Donnelly <and1000_at_cam.ac.uk>
wrote concerning 'Re: FVWM: RaiseWindow bug fix':
> On Wed, 12 Jun 1996, Richard Lister wrote:
>
> > Chuck, here's another bug fix for icons without a pixmap.
> >
> > PROBLEM:
> > If an icon without a pixmap is deiconified it comes up underneath
> > all other windows on the screen.
> >
> > CAUSE:
> > In RaiseWindow(), if there's no icon_pixmap_w then NULL gets pushed
> > onto the wins[] array, screwing up the call to XRestackWindows().
> >
> > TO FIX:
> > Test for icon_pixmap_w != NULL first. Here's the patch.
>
> Yup, I fixed this one about 1-2 months ago. Strangely enough, my
> patch was almost exactly yours :)

Aha! I should have checked the archive first :-). Strange that I missed
your fix when it was first posted ... I must have read that message
before my first coffee of the day!

Incidentally, I note Chuck said this doesn't happen under AIX. Is it
a bug in some implementations of XRestackWindows(), not treating the
array index i as authoritative and stopping at NULL array members?
Or a feature :-) I'm on Irix 6.2 (X11R6).

Ric

 ~~~~~~~~~~~~~~ Richard J. Lister r.j.lister_at_aston.ac.uk ~~~~~~~~~~~~~~~~
            Research Assistant, Neural Computing Research Group
                  Aston University, Birmingham B4 7ET, UK
 ~~~~~~~~~~~~~~~~~ http://www.ncrg.aston.ac.uk/~listerrj/ ~~~~~~~~~~~~~~~~~~
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Thu Jun 13 1996 - 06:17:03 BST

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:59 BST