FVWM: RaiseWindow bug fix

From: Richard Lister <listerrj_at_helios.aston.ac.uk>
Date: Wed, 12 Jun 1996 22:23:39 +0100

Chuck, here's another bug fix for icons without a pixmap.

PROBLEM:
If an icon without a pixmap is deiconified it comes up underneath
all other windows on the screen.

CAUSE:
In RaiseWindow(), if there's no icon_pixmap_w then NULL gets pushed
onto the wins[] array, screwing up the call to XRestackWindows().

TO FIX:
Test for icon_pixmap_w != NULL first. Here's the patch.

Ric


--- fvwm/misc.c.orig Wed Jun 12 22:12:19 1996
+++ fvwm/misc.c Wed Jun 12 22:17:30 1996
_at_@ -686,7 +686,9 @@
 #endif
   if ((t->flags & ICONIFIED)&&(!(t->flags & SUPPRESSICON)))
     {
- if(!(t->flags & NOICON_TITLE))wins[i++] = t->icon_w;
+ if(!(t->flags & NOICON_TITLE))
+ wins[i++] = t->icon_w;
+ if ( t->icon_pixmap_w != None )
       wins[i++] = t->icon_pixmap_w;
     }
   if(!(t->flags & ONTOP))


 ~~~~~~~~~~~~~~ Richard J. Lister r.j.lister_at_aston.ac.uk ~~~~~~~~~~~~~~~~
            Research Assistant, Neural Computing Research Group
                  Aston University, Birmingham B4 7ET, UK
 ~~~~~~~~~~~~~~~~~ http://www.ncrg.aston.ac.uk/~listerrj/ ~~~~~~~~~~~~~~~~~~
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Wed Jun 12 1996 - 16:31:34 BST

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:59 BST