Re: FVWM: Re: 5.0 stability

From: Dominik Vogt <dominik.vogt_at_gmx.de>
Date: Mon, 25 Mar 2002 00:19:15 +0100

On Sun, Mar 24, 2002 at 02:56:33PM -0500, Dan Espen wrote:
> Dominik Vogt <dominik.vogt_at_gmx.de> writes:
> > On Tue, Mar 12, 2002 at 09:41:18PM -0500, Dan Espen wrote:
> > > Dominik Vogt <dominik.vogt_at_gmx.de> writes:
> > > > On Mon, Mar 11, 2002 at 04:22:54PM -0500, Dan Espen wrote:
> > > > > Elliot Sowadsky <elliot_at_lsil.com> writes:
> > Finally, I am able to reproduce the problem. It does not happen
> > for all applications (xterm has the problem, rxvt and xemacs do
> > not).
>
> Everything works fine for me now.
>
> I was trying to track it down but when I noticed the EMWH
> code I just skipped over it.
>
> I had the problem with XEmacs and rxvt too.
> The only icon that didn't have the problem was xlogout which
> I start iconic and give an icon geometry.

I'm not sure why only xterm had the problem. It was hard to
understand all the stuff going on with the initial window state.
Hopefully, the cleaned up code will prove more robust in the
future. After all, it wasn't as complicated as we always thought,
only hard to understand because all of the global variables. The
information was passed doen a simple hierarchy:

  (Re)Capture code
    |
    v
  HandleMapRequestKeepRaised
    |
    V
  AddWindow (modified by session.c in MatchWinToSM)
    |
    v
  Placement code
    |
    v
  Icon placement code

Collecting the information in a struct and then passing it from
function to function was easy enough - with only a few side
entrances.

> > And the -dont-preserve-starte option to restart prevents it
> > too.
>
> Never use it, but that makes sense.

Actually, I wouldn't use it if a normal restart didn't preserve
the current viewport.

> > Note that it is usually correct to call Iconify with x/y =
> > 0 since the auto place code does not use these values normally.
>
> I see that now. Shouldn't this kind of thing be commented:
>
> Iconify(Fw,0,0); /* 0,0 is arbitrary */

Or better: write explanation of the arguments to Iconify(). I'll
write a few comments on the new data type. The Iconify()
arguments are gone anyway.

Bye

Dominik ^_^ ^_^

 --
Dominik Vogt, dominik.vogt_at_gmx.de
Reply-To: dominik.vogt_at_gmx.de
--
Visit the official FVWM web page at <URL: http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_fvwm.org.
To report problems, send mail to fvwm-owner_at_fvwm.org.
Received on Sun Mar 24 2002 - 17:16:56 GMT

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:52 BST