On Mon, Mar 11, 2002 at 06:55:54PM -0700, Gregg Dameron wrote:
> The Solaris C compiler (acc) complains when building fvwm2. In our shop
> we tend to get nervous about such things, since we will be providing
> systems (with fvwm2 installed) to our end users, and must answer to any
> bug reports they submit. (They have a real knack for exposing weird,
> intermittent anomalies.) As a result, we've developed a healthy respect
> for compiler warnings. What follows are the warnings from a build of
> 2.4.6. Any plans to address these?
>
> Gregg Dameron
>
>
> "../config.h", line 91: warning: syntax error: empty declaration
> (or)
> "../../config.h", line 91: warning: syntax error: empty declaration
> (many, many of these - these warnings are new since 2.4.5)
Forget these; generated by configure.
>
> "FScreen.c", line 1005: warning: argument #4 is incompatible with
> prototype:
> prototype: pointer to unsigned int : "FScreen.c", line 839
> argument : pointer to int
Ignore any signed/unsigned warnings. It's almost impossible to
fix these without breaking lots of code.
> "menus.c", line 7629: warning: argument #6 is incompatible with
> prototype:
> prototype: pointer to int : "../libs/FScreen.h", line 48
> argument : pointer to unsigned int
> "menus.c", line 7675: warning: end-of-loop code not reached
That's quite intentional.
> "bindings.c", line 321: warning: statement not reached
Nothing critical. Should have been detected by compiling with
-Wall though.
> "FvwmConsoleC.c", line 56: warning: argument #2 is incompatible with
> prototype:
> prototype: pointer to function(int) returning void :
> "/usr/include/signal.h", line 46
> argument : pointer to function() returning void
> "FvwmConsoleC.c", line 57: warning: argument #2 is incompatible with
> prototype:
> prototype: pointer to function(int) returning void :
> "/usr/include/signal.h", line 46
> argument : pointer to function() returning void
Nothing important, but I'll still fix it.
> "readconfig.c", line 1533: warning: enum type mismatch: op "="
> "readconfig.c", line 1535: warning: enum type mismatch: op "="
> "readconfig.c", line 1537: warning: enum type mismatch: op "="
> "readconfig.c", line 1544: warning: enum type mismatch: op "="
> "readconfig.c", line 1544: warning: enum type mismatch: op "="
Harmless but unnecessary.
> "xmanager.c", line 1653: warning: statement not reached
That warning is brain dead. It says that the final "return" in
the function is not reached. I'll still remove it.
> "FvwmTheme.c", line 684: warning: argument #6 is incompatible with
> prototype:
> prototype: pointer to unsigned int : "../../libs/fvwmlib.h",
> line 342
> argument : pointer to int
> "FvwmTheme.c", line 684: warning: argument #7 is incompatible with
> prototype:
> prototype: pointer to unsigned int : "../../libs/fvwmlib.h",
> line 342
> argument : pointer to int
Ignore these.
> "icons.c", line 278: warning: statement not reached
> "icons.c", line 317: warning: statement not reached
There are two reasons why I don't compile with -pedantic: First,
it's almost impossible to get all the signed/unsigned warnings
fixed. Second, I could never find any bug in the code with that
option and it complains about a lot of useless stuff.
Bye
Dominik ^_^ ^_^
--
Dominik Vogt, dominik.vogt_at_gmx.de
Reply-To: dominik.vogt_at_gmx.de
--
Visit the official FVWM web page at <URL: http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_fvwm.org.
To report problems, send mail to fvwm-owner_at_fvwm.org.
Received on Tue Mar 12 2002 - 17:46:11 GMT