FVWM: Proposed patch (Was: Function for toggling between windows?)

From: Markus Gutschke <gutschk_at_uni-muenster.de>
Date: Fri, 7 Mar 1997 15:09:52 +0100

[ This is part of a private e-mail exchange between Wolf and me. I
  figured, the list might be interested in this as well.
  Wolf, I hope you do not mind that I quote your message, here. If you
  do, then please flame me in e-mail :-) ]

Christopher Wolf writes:
> The mouse-focus routines do not update the windowlist the way the
> click-focus routines do, i.e. move the last clicked window to the
> front. The mouse-focus seems to only put new windows in the front.
> The FlipFocus is different from focus in that instead of moving it to
> the front of the windowlist, it flips the position of the stated
> window with that in the leading position, hence the need for
> Prev-Flipfocus. *Supposedly*, changing mouse-focus to move windows
> like click-focus would bog down the interface, especially as one
> moved around the screen. I can believe this, but it seems like
> alowances could be made, like a minimum transient time, or just always
> keeping track of the last two windows in a separate structure, and
> not actually reordering the windowlist per se.
>
> I'd *love* to use this function, but it never works correctly, and
> no-one seems to be willing into looking into changes.

I whipped up a really simple patch that might improve the behavior of
"FlipFocus" when used in mouse-focus mode. I have done *very* little
testing and it is quite possible that this patch breaks some other
functionality. First impressions suggest, that the new behavior is
more correct than the old one. As I do not fully understand FVWM's
internal handling of window lists, I would very much appreciate if
somebody else took a close look at this fix and checks that it takes
the right approach.


Markus

--- events.c.orig Fri Mar 7 14:58:06 1997
+++ events.c Fri Mar 7 14:47:03 1997
_at_@ -1117,12 +1117,16 @@
   
   if(!(Tmp_win->flags & ClickToFocus))
     {
+#if 0
       if(Scr.Focus != Tmp_win)
         {
           SetFocus(Tmp_win->w,Tmp_win,0);
         }
       else
         SetFocus(Tmp_win->w,Tmp_win,0);
+#else
+ SetFocus(Tmp_win->w,Tmp_win,1);
+#endif
     }
   if (Scr.ColormapFocus == COLORMAP_FOLLOWS_MOUSE)
   {


-- 
Markus Gutschke          Internet:       gutschk_at_math.uni-muenster.de
Schlage 5a               PGP public key: finger -l gutschk_at_math.uni-muenster.de
D-48268 Greven-Gimbte
Germany                            >>> I prefer encrypted e-mail <<<


--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Fri Mar 07 1997 - 08:47:43 GMT

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:38:00 BST