Re: FVWM: fvwm crashing

From: Charles Hines <>
Date: Fri, 14 Jun 1996 10:09:30 -0400

Whoops! Messed up that 1.24r patch slightly. This one should
actually be it:

======================================================================
diff -u -r ./fvwm-1.24r/ChangeLog ./fvwm-1.24rb/ChangeLog
--- ./fvwm-1.24r/ChangeLog Mon Dec 5 12:40:27 1994
+++ ./fvwm-1.24rb/ChangeLog Mon Jan 9 16:33:28 1995
_at_@ -1,3 +1,12 @@
+ra to rb
+ 1. Changed way click-to-focus problem was fixed to using only
+ CurrentTime instead of more elaborate fix, because it was
+ core dumping a lot for some reason.
+
+r to ra
+ 1. Fixed click-to-focus problem with clicking on Motif menubars
+ to exit a program causing focus to be lost.
+
 q to r
       1. Fixed blatant GoodStuff boo-boo, with the 'Swallow' command.

diff -u -r ./fvwm-1.24r/fvwm/borders.c ./fvwm-1.24rb/fvwm/borders.c
--- ./fvwm-1.24r/fvwm/borders.c Tue Dec 6 10:16:14 1994
+++ ./fvwm-1.24rb/fvwm/borders.c Mon Jan 9 16:11:55 1995
_at_@ -1205,7 +1205,7 @@
                  }
              Scr.Focus = NULL;
              Scr.Ungrabbed = NULL;
- XSetInputFocus(dpy, Scr.NoFocusWin,RevertToParent,lastTimestamp);
+ XSetInputFocus(dpy, Scr.NoFocusWin,RevertToParent,CurrentTime);
            }
          return;
        }
_at_@ -1254,30 +1254,30 @@

   if(Scr.flags & Lenience)
     {
- XSetInputFocus (dpy, w, RevertToParent, lastTimestamp);
+ XSetInputFocus (dpy, w, RevertToParent, CurrentTime);
       Scr.Focus = Fw;
     }
   else if(!((Fw)&&(Fw->wmhints)&&(Fw->wmhints->flags & InputHint)&&
            (Fw->wmhints->input == False)))
     {
       /* Window will accept input focus */
- XSetInputFocus (dpy, w, RevertToParent, lastTimestamp);
+ XSetInputFocus (dpy, w, RevertToParent, CurrentTime);
       Scr.Focus = Fw;
     }
   else if ((Scr.Focus)&&(Scr.Focus->Desk == Scr.CurrentDesk))
     {
       /* Window doesn't want focus. Leave focus alone */
- XSetInputFocus (dpy,Scr.Hilite->w , RevertToParent, lastTimestamp);
+ XSetInputFocus (dpy,Scr.Hilite->w , RevertToParent, CurrentTime);
     }
   else
     {
- XSetInputFocus (dpy, Scr.NoFocusWin, RevertToParent, lastTimestamp);
+ XSetInputFocus (dpy, Scr.NoFocusWin, RevertToParent, CurrentTime);
       Scr.Focus = NULL;
     }


   if ((Fw)&&(Fw->flags & DoesWmTakeFocus))
- send_clientmessage (w,_XA_WM_TAKE_FOCUS, lastTimestamp);
+ send_clientmessage (w,_XA_WM_TAKE_FOCUS, CurrentTime);

   XSync(dpy,0);

diff -u -r ./fvwm-1.24r/version.h ./fvwm-1.24rb/version.h
--- ./fvwm-1.24r/version.h Mon Dec 5 12:39:55 1994
+++ ./fvwm-1.24rb/version.h Mon Jan 9 16:31:03 1995
_at_@ -1,2 +1,2 @@
-#define VERSION "1.24r"
+#define VERSION "1.24rb"

--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.

Received on Fri Jun 14 1996 - 09:17:32 BST