Re: FVWM: Two small bugs in fvwm-2.0.42

From: Martin Kraemer <Martin.Kraemer_at_mch.sni.de>
Date: Fri, 19 Apr 1996 15:09:14 +0200 (MET DST)

Romano Giannetti wrote,...
> On Thu, 18 Apr 1996, Andrew Veliath wrote:
>
> > Anyone still experience the sticky windows problem? I find it much
> > more pronounced when the system is under load.
>
> Go to the title bar. Click. Pointer became a black dot. Wait, and after a
> while it is tranformed in a "four-arrows" one. Now, if you repeat the
> procedure and could release the button just at the same time the
> dot->four-arrows transformation happens, a move is triggered and
> you have the glued windows. The notion of "just at the same time"
> change with load ...

There was a patch from Robert Nation (the original fvwm author) for fvwm-2.0.40
which was sent to this list in a "verbal" (i,e, not machine readable) form.
I implemented the algorithm he suggested and kept it in my RCS history.

Well, I _do_ have a slower machine here which occasionally suffers heavy
load, so I this bug gave me a lot of trouble...

This patch cured the symptom for me, though it might not be the final
word on the topic (the detect-doubleclick-by-delay technique isn't the
best of all).

As far as I can tell, this patch should apply to 2.0.42 as well (I
thought is was incorporated anyway), so here it goes (NOTE: this was for
2.0.40, and I didn't test it for 2.0.42 yet!):
===================================================================
RCS file: RCS/complex.c,v
retrieving revision 2.0.40.1
retrieving revision 2.0.40.3
diff -b -u -r2.0.40.1 -r2.0.40.3
--- 2.0.40.1 1996/01/03 21:24:08
+++ 2.0.40.3 1996/01/04 16:11:33
_at_@ -38,17 +38,15 @@
 
   while((total < Scr.ClickTime)&&
         (x - xcurrent < 3)&&(x - xcurrent > -3)&&
- (y - ycurrent < 3)&&(y - ycurrent > -3))
+ (y - ycurrent < 3)&&(y - ycurrent > -3)&&
+ ((lastTimestamp - t0) < Scr.ClickTime))
     {
- sleep_a_little(10000);
- total+=10;
+ sleep_a_little(20000);
+ total+=20;
       if(XCheckMaskEvent (dpy,EndMask, d))
         {
           StashEventTime(d);
- if((lastTimestamp - t0) < Scr.ClickTime)
             return True;
- else
- return False;
         }
       if(XCheckMaskEvent (dpy,ButtonMotionMask|PointerMotionMask, d))
         {

    Martin
-- 
| S I E M E N S |   Martin.Kraemer_at_mch.sni.de   |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Fri Apr 19 1996 - 08:06:44 BST

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:58 BST