Re: FVWM: [2.0.41] fvwm core on bad Event.type

From: Charles Hines <>
Date: Wed, 13 Mar 1996 14:45:16 -0500

>>>>> "Paul" == Paul D Smith <psmith_at_BayNetworks.com> writes:

Paul> Yep, you're right; I just attached to my fvwm2 and looked up
Paul> ShapeEventBase, and it's 64; the X include files say ShapeNotify
Paul> is 0, so voila!

That'd do it...

Paul> I guess your only alternative to making the array 256 is to
Paul> dynamically allocate the event table to be the proper size after
Paul> you determine what ShapeEventBase+ShapeNotify is, since
Paul> ShapeEventBase is a runtime value.

I'll go to 256. The 'wasted' memory is pretty insignificant.

Paul> I'll make the change in my FVWM sources, thanks.

No problem. Sorry it gave you such grief - I should have caught this
before I sent it out. I'm going try to compile it under SunOS or
Solaris and check it w/ Purify to make sure I didn't do anything else
silly like this...

And the default is now 256 (for the next release):

--------------->8 cut here 8<---------------
--- ../../fvwm-2.0.41/fvwm/events.c Sun Feb 18 19:08:36 1996
+++ ./events.c Wed Mar 13 14:36:31 1996
_at_@ -87,9 +87,12 @@
 Window PressedW;

 /*
-** number of X events defined - it should be defined in X.h (to be
-** like 35), but just in case...
+** LASTEvent is the number of X events defined - it should be defined
+** in X.h (to be like 35), but since extension (eg SHAPE) events are
+** numbered beyond LASTEvent, we need to use a bigger number than the
+** default, so let's undefine the default and use 256 instead.
 */
+#undef LASTEvent
 #ifndef LASTEvent
 #define LASTEvent 256
 #endif /* !LASTEvent */
--------------->8 cut here 8<---------------

I CC'd the mailing list in case anyone else out there needs to apply
this patch. I'll put it on the LATEST NEWS section of the home page
too.

Chuck
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Wed Mar 13 1996 - 13:45:54 GMT

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:58 BST