FVWM: [FVWM 2.0.37]: Two bugs

From: Jose M. Pereira <pereira_at_cocaina.inesc.pt>
Date: Tue, 10 Oct 95 18:28:37 +0100

1) FvwmButtons: Exec "" (don't "depress" the button) doesn't work.

Example:

*FvwmButtons Xv none Exec "" exec xv &

Produces a button, but when clicked on doesn't do anything but the message

/bin/sh: : cannot execute

Cause: the command line sent to sh starts w/ ""...

Patch (I think...)

*** FvwmButtons.c~ Tue Oct 10 18:11:50 1995
--- FvwmButtons.c Tue Oct 10 18:14:00 1995
***************
*** 376,382 ****
                          }
                        else
                          {
! i2 = 4;
                          }
                        tmp=safemalloc(strlen(Buttons[CurrentButton].action));
                        strcpy(tmp,"Exec ");
--- 376,382 ----
                          }
                        else
                          {
! i2++;
                          }
                        tmp=safemalloc(strlen(Buttons[CurrentButton].action));
                        strcpy(tmp,"Exec ");


2) A window w/ a "*" (or a "%") in its name is shown by the internal window
list as having a null name. The FvwmWinList module works correctly, but its
slowness and lack of usability puts it off...

Suggestion: (fvwm/menus.c, AddMenu f.) if a pixmap can't be found for a window
name including an escape character, maintain the initial string in the menu
entry. Sorry, don't have a patch, since AddMenu() & friends are truly
obfuscated code...

Keep on the good work, Chuck.

-- 
Jose' Pereira
	     INESC (Inst. Eng. Sistemas e Computadores)
             R. Alves Redol 9, 6. 1000 Lisboa, PORTUGAL.
             Phone.: +351 1 3100223 Fax...: +351 1 525843
 e-mail: jmp_at_inesc.pt PGP PUBLIC KEY: finger -m pereira @sabrina.inesc.pt
		<< Hit any user to continue >>
--
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Tue Oct 10 1995 - 12:25:23 BST

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:57 BST