On 14 Dec 2003 09:57:15 +0100, Olivier Chapuis wrote:
>
> On Sun, Dec 14, 2003 at 02:21:47AM +0000, Mikhael Goikhman wrote:
> > On 12 Dec 2003 13:32:07 +0100, Olivier Chapuis wrote:
> > >
> > > On Thu, Dec 11, 2003 at 12:34:47AM +0000, Mikhael Goikhman wrote:
> > >
> > > http://fvwm-themes.sourceforge.net/patch/fvwm-metisse-2.5.8.patch.bz2
> > >
> >
> > This patch should really be reduced and divided to several patches. In
> > the current state (730Kb) it patches things that should never be patched.
> > Seeing how many problems "patch -p1 --dry-run" produces, I think I will
> > wait for a clean "cvs diff" patch.
> >
>
> The problem is that the patch change configure.in and acconfig.h. So a
> cvs diff patch will do not work if you do not run /utils/configure_dev.sh
> in the place of configure and in theory you should not require
> automake and autoconf for installing a package. The patch is big
> because 2.5.8 is builded with automake-1.6.3 and I use automake-1.7.3
> (if you want a small patch, I suggest you use 1.7.3 for building 2.5.9
> :o, I do not care about the size of this patch)
Ok, I will install the latest automake when this happens.
> What problems cause "patch -p1 --dry-run" run on a *fresh* fvwm-2.5.8
> source tree?
I know that it should not cause problems on released tarball, I just said
I will probably wait for a clean patch for cvs myself. :)
Ok, I did the following trick for myself:
cvs ... checkout -d fvwm-2.5.8 -r version-2_5_8 fvwm
tar xzf fvwm-2.5.8.tar.gz
patch -p0 <fvwm-metisse-2.5.8.patch
cd fvwm-2.5.8
rm depcomp # should be in .cvsignore
cvs diff >fvwm-metisse-dev.patch
diff -u -N /dev/null README.PATCH >>fvwm-metisse-dev.patch
diff -u -N /dev/null libs/FTransparency.h >>fvwm-metisse-dev.patch
diff -u -N /dev/null libs/FTransparency.c >>fvwm-metisse-dev.patch
The resulting patch is here:
http://fvwm-themes.sourceforge.net/patch/fvwm-metisse-dev.patch.bz2
It is still problematic to be applied to cvs, but less problematic,
and it should be easier for someone to fix this. I also removed all
unrelated files manually and here is the reduced version (it now seem
to include only 2 separate things, function grabs and translucency):
http://fvwm-themes.sourceforge.net/patch/fvwm-metisse-dev2.patch.bz2
> Yes, it will be good to split the patch, however I do not have the
> time to maintain 2 of 3 patches. What will happen is that I will not
> maintain the translucency part of the patch and simply remove it from
> my "special" cvs source tree (this part causes problem, as you noted,
> because it implies patching configure.in and acconfig.h). Moreover, I
> do not need/used this part of the patch.
>
> So, if someone want to maintain the translucency part of the patch
> (and can/want run the XDirectFB X server), he/she is welcome (I can
> help at the beginning).
>
> So, I will not split the patch, I will not maintain this patch as is
> and I will not make more publicity for this patch. I need some part of
> this patch for myself and metisse (a private project for now, but not
> for so long). However, as I thought that some fvwm users like
> translucency I post it to the fvwm-users list.
What I meant is that some parts of the patch, like changes to INSTALL,
fvwm-menu-desktop, system.fvwm2rc-sample-95 and other files may be just
commited into the mainline.
The pure translucency part of the patch does not seem to be very big, so
someone (not me) may update man pages and try to push it into mainline.
Regards,
Mikhael.
--
Visit the official FVWM web page at <URL: http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_fvwm.org.
To report problems, send mail to fvwm-owner_at_fvwm.org.
Received on Sun Dec 14 2003 - 11:57:51 GMT